linux-kernel - Re: [PATCH] dmaengine: squash lines for immediate return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c992f57-8397-d46a-59be-55dd9457e890@nvidia.com>
Date:   Tue, 13 Sep 2016 09:45:18 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        <dmaengine@...r.kernel.org>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Peter Griffin <peter.griffin@...aro.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Stephen Warren <swarren@...dotorg.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vinod.koul@...el.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        "Alexandre Courbot" <gnurou@...il.com>
Subject: Re: [PATCH] dmaengine: squash lines for immediate return


On 12/09/16 20:20, Masahiro Yamada wrote:
> Remove unneeded variables and assignments.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/dma/cppi41.c          | 30 +++++-------------------------
>  drivers/dma/imx-sdma.c        | 15 ++++-----------
>  drivers/dma/ppc4xx/adma.c     | 15 ++++++---------
>  drivers/dma/tegra20-apb-dma.c |  4 +---
>  4 files changed, 16 insertions(+), 48 deletions(-)

...

> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 6ab9eb9..89795a2 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -337,9 +337,7 @@ static struct tegra_dma_sg_req *tegra_dma_sg_req_get(
>  	}
>  	spin_unlock_irqrestore(&tdc->lock, flags);
>  
> -	sg_req = kzalloc(sizeof(struct tegra_dma_sg_req), GFP_NOWAIT);
> -
> -	return sg_req;
> +	return kzalloc(sizeof(struct tegra_dma_sg_req), GFP_NOWAIT);
>  }
>  
>  static int tegra_dma_slave_config(struct dma_chan *dc,

For the Tegra bit ...

Acked-by: Jon Hunter <jonathanh@...dia.com>

Cheers
Jon

-- 
nvpublic