linux-kernel - Re: [PATCH 2/6] mfd: as3722: convert MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160913085225.GB24465@dell>
Date:   Tue, 13 Sep 2016 09:52:25 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
        Florian Lobmaier <florian.lobmaier@....com>,
        Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH 2/6] mfd: as3722: convert MFD_AS3722 from bool to tristate

On Mon, 12 Sep 2016, Paul Gortmaker wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_AS3722
> drivers/mfd/Kconfig:    bool "ams AS3722 Power Management IC"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> In response to an earlier patch set suggesting removal of the unused
> modular code, Laxman suggested that this driver be instead moved to
> tristate.
> 
> We do that here, and confirm it can build and modpost as a tristate.
> However there remains to be runtime testing in order to ensure this
> change is 100% functional for "=m".
> 
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Florian Lobmaier <florian.lobmaier@....com>
> Cc: Laxman Dewangan <ldewangan@...dia.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 9ac9f6250ba8..9a529bf06eed 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -50,7 +50,7 @@ config MFD_AS3711
>  	  Support for the AS3711 PMIC from AMS
>  
>  config MFD_AS3722
> -	bool "ams AS3722 Power Management IC"
> +	tristate "ams AS3722 Power Management IC"
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	select REGMAP_IRQ

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog