linux-kernel - Re: [PATCH 5/6] mfd: sun6i-prcm: Make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160913085301.GE24465@dell>
Date:   Tue, 13 Sep 2016 09:53:01 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Boris BREZILLON <boris.brezillon@...e-electrons.com>
Subject: Re: [PATCH 5/6] mfd: sun6i-prcm: Make it explicitly non-modular

On Mon, 12 Sep 2016, Paul Gortmaker wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_SUN6I_PRCM
> drivers/mfd/Kconfig:    bool "Allwinner A31 PRCM controller"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modularity so that when reading the
> driver there is no doubt it is builtin-only.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Boris BREZILLON <boris.brezillon@...e-electrons.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/mfd/sun6i-prcm.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/sun6i-prcm.c b/drivers/mfd/sun6i-prcm.c
> index 191173166d65..011fcc555945 100644
> --- a/drivers/mfd/sun6i-prcm.c
> +++ b/drivers/mfd/sun6i-prcm.c
> @@ -9,7 +9,7 @@
>   */
>  
>  #include <linux/mfd/core.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/of.h>
>  
>  struct prcm_data {
> @@ -170,8 +170,4 @@ static struct platform_driver sun6i_prcm_driver = {
>  	},
>  	.probe = sun6i_prcm_probe,
>  };
> -module_platform_driver(sun6i_prcm_driver);
> -
> -MODULE_AUTHOR("Boris BREZILLON <boris.brezillon@...e-electrons.com>");
> -MODULE_DESCRIPTION("Allwinner sun6i PRCM driver");
> -MODULE_LICENSE("GPL v2");
> +builtin_platform_driver(sun6i_prcm_driver);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog