linux-kernel - [Question] Calling request_firmware under the spinlocks in file advansys.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2016 14:48:40 +0530
From:   Vaishali Thakkar <vaishali.thakkar@...cle.com>
To:     Matthew Wilcox <matthew@....cx>, Hannes Reinecke <hare@...e.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [Question] Calling request_firmware under the spinlocks in file
 advansys.c

Hi,

In the file drivers/scsi/advansys.c we are calling function AdvISR at 2 instances
[in the function advansys_reset and advansys_interrupt] while holding spinlock.
Function AdvISR eventually calls request_firmware following this sequence of
routines: 

AdvISR -> adv_async_callback -> AdvResetChipAndSB -> AdvInitAsc3550Driver ->
request_firmware

According to the definition of request_firmware it should be called from user
context where sleeping is allowed. And usually sleeping under the spin lock is
not allowed. Is it really necessary to call AdvISR under spinlocks here? Are
we taking care of sleeping related concern of request_firmware or am I
overlooking something here?

Thank you.

-- 
Vaishali