linux-kernel - Re: [PATCH v11 5/8] clocksource/drivers/arm_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADyBb7tWP=_zu+Pu0UC1E6u+yAgH06peh8rt3hS6-O42K3kPNQ@mail.gmail.com>
Date:   Tue, 13 Sep 2016 18:21:22 +0800
From:   Fu Wei <fu.wei@...aro.org>
To:     Mark Rutland <mark.rutland@....com>,
        Marc Zyngier <marc.zyngier@....com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Hanjun Guo <hanjun.guo@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        Linaro ACPI Mailman List <linaro-acpi@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        rruigrok@...eaurora.org, "Abdulhamid, Harb" <harba@...eaurora.org>,
        Christopher Covington <cov@...eaurora.org>,
        Timur Tabi <timur@...eaurora.org>,
        G Gregory <graeme.gregory@...aro.org>,
        Al Stone <al.stone@...aro.org>, Jon Masters <jcm@...hat.com>,
        Wei Huang <wei@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        Wim Van Sebroeck <wim@...ana.be>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
        Leo Duran <leo.duran@....com>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-watchdog@...r.kernel.org,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI
 support code.

Hi Mark, Marc,

Sorry for missing you in the cc list
Do you have any suggestion for the  arm_arch_timer patches?
Could you help me to review these patches ?

Great thanks !

On 13 September 2016 at 17:22, Fu Wei <fu.wei@...aro.org> wrote:
> Hi Thomas, Daniel,
>
> For these  arm_arch_timer patches, do you have any other suggestion or comment?
> I have deleted "skipping" in the error message.
>
> I have prepared v12 (rebase to rc6 and on the top of IORT v11),
> should I send it now (if you are OK with my arm_arch_timer patches ),
> or anything I can do to improve this patchset ?
>
> Thanks.
>
> On 7 September 2016 at 17:23, Fu Wei <fu.wei@...aro.org> wrote:
>> Hi Thomas
>>
>> On 6 September 2016 at 22:36, Thomas Gleixner <tglx@...utronix.de> wrote:
>>> On Tue, 6 Sep 2016, fu.wei@...aro.org wrote:
>>>> +     if (timer_count < 0)
>>>> +             pr_err("Failed to get platform timer info, skipping.\n");
>>>
>>> So this prints something about skipping. But then it continues as if
>>> nothing went wrong. That's either wrong or confusing or both.
>>
>> yes, you are right, this info is confusing.
>> maybe we just delete the "skipping" ?
>>
>> “timer_count < 0” is caused by some firmware bug, in gtdt.c:
>> ----
>> int __init acpi_gtdt_init(struct acpi_table_header *table)
>> {
>> ......
>>         if (start < (void *)table + sizeof(struct acpi_table_gtdt)) {
>>         pr_err(FW_BUG "Failed to retrieve timer info from firmware:
>> invalid data.\n");
>>         return -EINVAL;
>> ......
>> }
>> ----
>>
>> But in this situation( without platform timers ), system still can work.
>> So I thing we just need to print a error.
>>
>>>
>>>> -     arch_timer_init();
>>>> -     return 0;
>>>> +     return arch_timer_init();
>>>
>>> Thanks,
>>>
>>>         tglx
>>
>>
>>
>> --
>> Best regards,
>>
>> Fu Wei
>> Software Engineer
>> Red Hat
>
>
>
> --
> Best regards,
>
> Fu Wei
> Software Engineer
> Red Hat



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat