linux-kernel - Re: [PATCH] rk808: fix RK818_IRQ_DISCHG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160913104826.GB26864@dell>
Date:   Tue, 13 Sep 2016 11:48:26 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andy Yan <andy.yan@...k-chips.com>,
        Wadim Egorov <w.egorov@...tec.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rk808: fix RK818_IRQ_DISCHG_ILIM initializer

On Tue, 06 Sep 2016, Arnd Bergmann wrote:

> When building with -Woverride-init, we get a warning about an incorrect
> initializer:
> 
> drivers/mfd/rk808.c:244:8: error: initialized field overwritten [-Werror=override-init]
>   [RK818_IRQ_DISCHG_ILIM] = {
> 
> This is clearly a mistake, as both RK818_IRQ_DISCHG_ILIM and RK818_IRQ_USB_OV
> are defined as '7', but they refer to different register bits. Changing
> RK818_IRQ_DISCHG_ILIM to 15 is consistent with how all other 14 interrupts are
> handled here, so I'm assuming this is what it should have been.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 2eedcbfc0612 ("mfd: rk808: Add RK818 support")
> ---
>  include/linux/mfd/rk808.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I would like someone who is in possession of a datasheet to confirm
this.

> diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
> index fc5db6fcb57d..6d435a3c06bc 100644
> --- a/include/linux/mfd/rk808.h
> +++ b/include/linux/mfd/rk808.h
> @@ -244,7 +244,7 @@ enum rk818_reg {
>  #define RK818_IRQ_CHG_TS1	12
>  #define RK818_IRQ_TS2		13
>  #define RK818_IRQ_CHG_CVTLIM	14
> -#define RK818_IRQ_DISCHG_ILIM	7
> +#define RK818_IRQ_DISCHG_ILIM	15
>  
>  #define RK818_IRQ_VOUT_LO_MSK		BIT(0)
>  #define RK818_IRQ_VB_LO_MSK		BIT(1)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog