linux-kernel - Re: [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2016 13:42:15 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Axel Lin <axel.lin@...ics.com>
Cc:     Keerthy <j-keerthy@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x

On Tue, 06 Sep 2016, Axel Lin wrote:

> The mutex is not used, so remove it.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/mfd/lp873x.c       | 2 --
>  include/linux/mfd/lp873x.h | 1 -
>  2 files changed, 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c
> index 9af064c..873c608 100644
> --- a/drivers/mfd/lp873x.c
> +++ b/drivers/mfd/lp873x.c
> @@ -53,8 +53,6 @@ static int lp873x_probe(struct i2c_client *client,
>  		return ret;
>  	}
>  
> -	mutex_init(&lp873->lock);
> -
>  	ret = regmap_read(lp873->regmap, LP873X_REG_OTP_REV, &otpid);
>  	if (ret) {
>  		dev_err(lp873->dev, "Failed to read OTP ID\n");
> diff --git a/include/linux/mfd/lp873x.h b/include/linux/mfd/lp873x.h
> index 83b1bd7..edbec83 100644
> --- a/include/linux/mfd/lp873x.h
> +++ b/include/linux/mfd/lp873x.h
> @@ -263,7 +263,6 @@ enum lp873x_regulator_id {
>  struct lp873x {
>  	struct device *dev;
>  	u8 rev;
> -	struct mutex lock;	/* lock guarding the data structure */
>  	struct regmap *regmap;
>  };
>  #endif /* __LINUX_MFD_LP873X_H */

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog