linux-kernel - Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e5928e0-7a7a-915e-1090-726cc502f3ce@canonical.com>
Date:   Tue, 13 Sep 2016 13:45:29 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>
Cc:     Phil Reid <preid@...ctromag.com.au>,
        Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning
 garbage

On 13/09/16 13:46, Linus Walleij wrote:
> On Tue, Sep 13, 2016 at 2:31 PM, Arnd Bergmann <arnd@...db.de> wrote:
> 
>> Please try to avoid adding initializations in the local variable
>> declaration, they just hide otherwise useful warnings when
>> you get a function that actually does something incorrect
>> in some code paths.
> 
> Agreed, sorry for my ignorance :(
> 
> I duly corrected the git and reverted the other patch instead of yours.
> 
> Yours,
> Linus Walleij
> 
Makes sense. Thanks Linus