linux-kernel - Re: [PATCH v2] mm: move phys_mem_access_prot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2016 14:50:12 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
cc:     ralf@...ux-mips.org, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, arnd@...db.de, akpm@...ux-foundation.org,
        paul.burton@...tec.com, chenhc@...ote.com, david.daney@...ium.com,
        kumba@...too.org, yamada.masahiro@...ionext.com,
        kirill.shutemov@...ux.intel.com, dave.hansen@...ux.intel.com,
        toshi.kani@....com, dan.j.williams@...el.com, luto@...nel.org,
        JBeulich@...e.com, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH v2] mm: move phys_mem_access_prot_allowed() declaration
 to pgtable.h

On Tue, 13 Sep 2016, Baoyou Xie wrote:

> We get 1 warning when building kernel with W=1:
> drivers/char/mem.c:220:12: warning: no previous prototype for 'phys_mem_access_prot_allowed' [-Wmissing-prototypes]
>  int __weak phys_mem_access_prot_allowed(struct file *file,
> 
> In fact, its declaration is spreading to several header files
> in different architecture, but need to be declare in common
> header file.
> 
> So this patch moves phys_mem_access_prot_allowed() to pgtable.h.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  arch/mips/include/asm/pgtable.h      | 2 --
>  arch/x86/include/asm/pgtable_types.h | 2 --
>  include/asm-generic/pgtable.h        | 3 +++
>  3 files changed, 3 insertions(+), 4 deletions(-)

Acked-by: Thomas Gleixner <tglx@...utronix.de>