linux-kernel - Re: [PATCH] MIPS: rb532: Fix undefined reference to setup_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160913160251.GC20655@linux-mips.org>
Date:   Tue, 13 Sep 2016 18:02:52 +0200
From:   Ralf Baechle <ralf@...ux-mips.org>
To:     Matt Redfearn <matt.redfearn@...tec.com>
Cc:     linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: rb532: Fix undefined reference to setup_serial_port

On Mon, Sep 05, 2016 at 05:18:40PM +0100, Matt Redfearn wrote:

> If the rb532 machine is compiled without CONFIG_SERIAL_8250, the
> following linker error occurs
> 
> arch/mips/built-in.o: In function `setup_serial_port':
> (.init.text+0x20c): undefined reference to `early_serial_setup'
> 
> Fix this by wrapping registration of the rb532 uart in an ifdef
> CONFIG_SERIAL_8250.

This will still fail if CONFIG_SERIAL_8250 = m.

RB532 should be rewritten to use earl console rather than early_serial_setup
similar to https://git.linux-mips.org/cgit/ralf/linux.git/commit/?id=194d315da86af504559a8a21026360097575bd55
for example.

  Ralf