linux-kernel - Re: [PATCH] MIPS: Octeon: Use defines instead of magic numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160913193154.GC1658@raspberrypi.musicnaut.iki.fi>
Date:   Tue, 13 Sep 2016 22:31:54 +0300
From:   Aaro Koskinen <aaro.koskinen@....fi>
To:     Asbjørn Sloth Tønnesen <asbjorn@...jorn.st>
Cc:     Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Octeon: Use defines instead of magic numbers

Hi,

On Tue, Sep 13, 2016 at 07:04:54PM +0000, Asbjørn Sloth Tønnesen wrote:
> On Tue, 13 Sep 2016 00:03:14 +0300, Aaro Koskinen <aaro.koskinen@....fi> wrote:
> > On Mon, Sep 12, 2016 at 08:33:43PM +0000, Asbjoern Sloth Toennesen wrote:
> > > The patch will be followed by a similar patch to
> > > drivers/staging/octeon/ethernet.c
> > 
> > I think you should:
> > 
> > 	1. Move this function to staging/octeon
> > 
> > 	2. Do required cleanups there
> > 
> > 	3. Finally delete the function under arch/mips
> > 
> > We shouldn't start making cleanups (except code removal) to ethernet code
> > under mips/cavium-octeon/executive as it really does not belong there...
> 
> I agree that this would make sense, however I just came across this looking
> at the general MTU code across drivers, and don't have a real interest in
> this particular driver nor mips, so I am not looking to fall that deep into
> the rabbit hole.

In that case please leave the code alone. NAK for this patch.

A.