linux-kernel - Re: Question about suspend/resume clock handling in dwc3-of-simple.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bmzsl5uz.fsf@linux.intel.com>
Date:   Tue, 13 Sep 2016 08:35:16 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Question about suspend/resume clock handling in dwc3-of-simple.c


Hi,

Guenter Roeck <linux@...ck-us.net> writes:
>> > Should it be clk_disable_unprepare(), or maybe something like the
>> > following
>> >
>> > 	if (!pm_runtime_status_suspended(dev))
>> > 		clk_disable_unprepare();
>> > 	else
>> > 		clk_unprepare();
>> 
>> I'm not sure how balanced those calls are, yeah. I don't have HW to test
>> PM with. But note that as it is, there is no actual runtime PM support,
>> so clk_disable_unprepare() will always be necessary.
>> 
>> Perhaps we will find further issues when someone tries to use runtime PM
>> with dwc3-of-simple. ;-)
>> 
>
> We are working on code derived from it, so unless I can convince the author
> that he can not just use clk_unprepare() I suspect we'll hit the problem.
> If so, I'll let you know.

Are you sending that upstream? Depending on your requirements, it might
be easier to patch dwc3-of-simple.c then adding yet another glue layer :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)