linux-kernel - Re: [PATCH] mfd: tps65217: fix nonstandard declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2016 09:37:48 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Tony Lindgren <tony@...mide.com>,
        Marcin Niestroj <m.niestroj@...nn-global.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: tps65217: fix nonstandard declaration

On Wed, 14 Sep 2016, Arnd Bergmann wrote:

> The tps65217 gained a new warning when building with W=1:
> 
> drivers/mfd/tps65217.c:85:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
> 
> This fixes it by putting the 'inline' modifier before 'const'.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 262d5cc6ceb2 ("mfd: tps65217: Add support for IRQs")
> ---
>  drivers/mfd/tps65217.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

FYI: I plan to fix all W=1 and look at W=2 warnings today anyway.

> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
> index 57c87412106f..9a4d8684dd32 100644
> --- a/drivers/mfd/tps65217.c
> +++ b/drivers/mfd/tps65217.c
> @@ -82,7 +82,7 @@ static void tps65217_irq_sync_unlock(struct irq_data *data)
>  	mutex_unlock(&tps->irq_lock);
>  }
>  
> -static const inline struct tps65217_irq *
> +static inline const struct tps65217_irq *
>  irq_to_tps65217_irq(struct tps65217 *tps, struct irq_data *data)
>  {
>  	return &tps65217_irqs[data->hwirq];

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog