linux-kernel - Re: [PATCH 02/15] hisi_sas: save delivery queue write pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30d2ed09-d8b5-ef52-0bf5-847b4171e99c@suse.de>
Date:   Wed, 14 Sep 2016 13:47:35 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linuxarm@...wei.com, zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
        john.garry2@...l.dcu.ie, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/15] hisi_sas: save delivery queue write pointer

On 09/06/2016 05:36 PM, John Garry wrote:
> Optimise by saving an avoidable read in the
> get_free_slot function.
> The delivery queue write pointer will only be
> updated by software, so don't bother re-reading
> what was already written in the previous call
> to start_delivery function.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>  drivers/scsi/hisi_sas/hisi_sas.h       |  7 +++++++
>  drivers/scsi/hisi_sas/hisi_sas_main.c  |  5 +++++
>  drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 12 +++++++-----
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  9 ++++++---
>  4 files changed, 25 insertions(+), 8 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Cheers
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)