linux-kernel - Re: [Outreachy kernel] [PATCH] Staging: sm750fb: Use x instead of x != NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2016 14:35:41 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Sandhya Bankar <bankarsandhya512@...il.com>
cc:     outreachy-kernel@...glegroups.com, sudipm.mukherjee@...il.com,
        teddy.wang@...iconmotion.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] Staging: sm750fb: Use x instead of
 x != NULL



On Wed, 14 Sep 2016, Sandhya Bankar wrote:

> Use x instead of x != NULL .
> This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script .
> CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"

OK for the patch, but please put a space after the end of each sentence,
and don't allow the lines in your commit message to go over 80 characters.

julia

>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index a4a2550..8a39e0e 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -45,7 +45,7 @@ int dviInit(
>  	dvi_ctrl_device_t *pCurrentDviCtrl;
>
>  	pCurrentDviCtrl = g_dcftSupportedDviController;
> -	if (pCurrentDviCtrl->pfnInit != NULL) {
> +	if (pCurrentDviCtrl->pfnInit) {
>  		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
>  						vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
>  						pllFilterEnable, pllFilterValue);
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914123349.GA3770%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>