linux-kernel - Re: [PATCH 05/15] hisi_sas: use safe BITS_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2347d56f-bf51-5be7-431d-ae5162cb00c3@suse.de>
Date:   Wed, 14 Sep 2016 14:46:26 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linuxarm@...wei.com, zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
        john.garry2@...l.dcu.ie, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/15] hisi_sas: use safe BITS_PER_BYTE for slot tag size
 calculation

On 09/06/2016 05:36 PM, John Garry wrote:
> The memory calculation for the tags bitmap should use BITS_PER_BYTE
> macro instead of coincidental same value of sizeof(unsigned long).
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>  drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 0e48751..dcb17a3 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -1309,7 +1309,7 @@ static int hisi_sas_alloc(struct hisi_hba *hisi_hba, struct Scsi_Host *shost)
>  	memset(hisi_hba->breakpoint, 0, s);
>  
>  	hisi_hba->slot_index_count = max_command_entries;
> -	s = hisi_hba->slot_index_count / sizeof(unsigned long);
> +	s = hisi_hba->slot_index_count / BITS_PER_BYTE;
>  	hisi_hba->slot_index_tags = devm_kzalloc(dev, s, GFP_KERNEL);
>  	if (!hisi_hba->slot_index_tags)
>  		goto err_out;
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)