linux-kernel - Re: [PATCH 07/15] hisi_sas: fix phy8 linkrate calculation in phy_up_v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70901278-d9c9-fb66-d92a-22c8ba57fd08@suse.de>
Date:   Wed, 14 Sep 2016 14:47:24 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linuxarm@...wei.com, zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
        john.garry2@...l.dcu.ie, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Xiang Chen <chenxiang66@...ilicon.com>
Subject: Re: [PATCH 07/15] hisi_sas: fix phy8 linkrate calculation in
 phy_up_v2_hw()

On 09/06/2016 05:36 PM, John Garry wrote:
> In function phy_up_v2_hw(), we needlessly recalculate the
> phy linkrate for all phys, and the calculation is incorrect
> for phy8, so remove this code.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> Signed-off-by: Xiang Chen <chenxiang66@...ilicon.com>
> ---
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> index aca2b80..ae44443 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> @@ -1876,9 +1876,6 @@ static int phy_up_v2_hw(int phy_no, struct hisi_hba *hisi_hba)
>  		frame_rcvd[i] = __swab32(idaf);
>  	}
>  
> -	/* Get the linkrates */
> -	link_rate = hisi_sas_read32(hisi_hba, PHY_CONN_RATE);
> -	link_rate = (link_rate >> (phy_no * 4)) & 0xf;
>  	sas_phy->linkrate = link_rate;
>  	hard_phy_linkrate = hisi_sas_phy_read32(hisi_hba, phy_no,
>  						HARD_PHY_LINKRATE);
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)