linux-kernel - Re: [PATCH 14/15] hisi_sas: add missing SATA pending device type to v2 hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2016 14:51:16 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linuxarm@...wei.com, zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
        john.garry2@...l.dcu.ie, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Xiang Chen <chenxiang66@...ilicon.com>
Subject: Re: [PATCH 14/15] hisi_sas: add missing SATA pending device type to
 v2 hw

On 09/06/2016 05:36 PM, John Garry wrote:
> In setup_itct_v2_hw(), SATA device type SAS_SATA_PENDING
> is missing, so add it.
> 
> Note: The HiSi SAS controller does not support SATA PM,
>       so do not handle SAS_SATA_PM_PORT or SAS_SATA_PM.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> Signed-off-by: Xiang Chen <chenxiang66@...ilicon.com>
> ---
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> index 5925b93..735ebff 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> @@ -594,6 +594,7 @@ static void setup_itct_v2_hw(struct hisi_hba *hisi_hba,
>  		qw0 = HISI_SAS_DEV_TYPE_SSP << ITCT_HDR_DEV_TYPE_OFF;
>  		break;
>  	case SAS_SATA_DEV:
> +	case SAS_SATA_PENDING:
>  		if (parent_dev && DEV_IS_EXPANDER(parent_dev->dev_type))
>  			qw0 = HISI_SAS_DEV_TYPE_STP << ITCT_HDR_DEV_TYPE_OFF;
>  		else
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)