lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5a21833c-2e85-2092-f9a8-b3d023b03485@suse.de>
Date:   Wed, 14 Sep 2016 15:23:00 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Colin King <colin.king@...onical.com>,
        Kashyap Desai <kashyap.desai@...gotech.com>,
        Sumit Saxena <sumit.saxena@...gotech.com>,
        Uday Lingala <uday.lingala@...gotech.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        megaraidlinux.pdl@...gotech.com, linux-scsi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: megaraid_sas: add in missing white space in error
 message text

On 09/12/2016 02:42 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> A dev_printk message spans two lines and the literal string is missing
> a white space between words. Add the white space.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 2d62d71..c236c4d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
>  					     &instance->consumer_h);
>  
>  		if (!instance->producer || !instance->consumer) {
> -			dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate"
> +			dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate "
>  			       "memory for producer, consumer\n");
>  			goto fail_alloc_dma_buf;
>  		}
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ