linux-kernel - RE: [PATCH] ACPICA / Interpreter: Remove redundant newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E4FC413@ORSMSX110.amr.corp.intel.com>
Date:   Wed, 14 Sep 2016 14:03:42 +0000
From:   "Moore, Robert" <robert.moore@...el.com>
To:     "Zheng, Lv" <lv.zheng@...el.com>, Borislav Petkov <bp@...en8.de>,
        LKML <linux-kernel@...r.kernel.org>
CC:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "Box, David E" <david.e.box@...el.com>
Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline



> -----Original Message-----
> From: Zheng, Lv
> Sent: Tuesday, September 13, 2016 8:11 PM
> To: Moore, Robert <robert.moore@...el.com>; Moore, Robert
> <robert.moore@...el.com>; Borislav Petkov <bp@...en8.de>; LKML <linux-
> kernel@...r.kernel.org>
> Cc: linux-acpi@...r.kernel.org; devel@...ica.org; Wysocki, Rafael J
> <rafael.j.wysocki@...el.com>; Box, David E <david.e.box@...el.com>
> Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> 
> Hi,
> 
> > From: linux-acpi-owner@...r.kernel.org
> > [mailto:linux-acpi-owner@...r.kernel.org] On Behalf Of Moore, Robert
> > David E <david.e.box@...el.com>
> > Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline
> >
> > Well, I never thought I would write a couple lines of code like this,
> > but here is a solution that should make everyone happy.
> >
> > diff --git a/source/components/tables/tbxfload.c
> > b/source/components/tables/tbxfload.c
> > index 6a937b1..73ee1a2 100644
> > --- a/source/components/tables/tbxfload.c
> > +++ b/source/components/tables/tbxfload.c
> > @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
> >      if (!TablesFailed)
> >      {
> >          ACPI_INFO ((
> > -            "%u ACPI AML tables successfully acquired and loaded\n",
> > +            "%u ACPI AML tables successfully acquired and loaded",
> >              TablesLoaded));
> >      }
> >      else
> > @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
> >          Status = AE_CTRL_TERMINATE;
> >      }
> >
> > +#ifdef ACPI_APPLICATION
> > +    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n")); #endif
> > +
> > +
> 
[Moore, Robert] 

I have no problem with this, I just want to get it over with.
It is not a big deal, let's leave it at that and not make it a big issue.





> IMO, these lines should be in ACPICA upstream, in a file under
> tools/acpiexec.
> 
> Thanks
> Lv
> 
> >  UnlockAndExit:
> >      (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
> >      return_ACPI_STATUS (Status);
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi"
> > in the body of a message to majordomo@...r.kernel.org More majordomo
> > info at  http://vger.kernel.org/majordomo-info.html