linux-kernel - Re: [PATCH] driver-core: platform: Catch errors from calls to irq_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e446695b-2e89-25bc-0037-5036fbe656ab@roeck-us.net>
Date:   Wed, 14 Sep 2016 07:29:23 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
Subject: Re: [PATCH] driver-core: platform: Catch errors from calls to
 irq_get_irq_data

On 09/14/2016 02:44 AM, Greg Kroah-Hartman wrote:
> On Wed, Sep 14, 2016 at 11:06:08AM +0200, Linus Walleij wrote:
>> On Wed, Sep 14, 2016 at 5:32 AM, Guenter Roeck <linux@...ck-us.net> wrote:
>>
>>> irq_get_irq_data() can return NULL, which results in a nasty crash.
>>> Check its return value before passing it on to irqd_set_trigger_type().
>>>
>>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>>
>> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>>
>> Should probably be tagged for stable.
>
> Why, are there any systems that are currently broken without this change
> right now?
>
I only see it in -next, and that is due to a patch there.

Guenter