linux-kernel - Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFHUOYxMOpz2xOQuVpi6y3nVrVF_ihzX9jj-0PLwkckrJFJUXw@mail.gmail.com>
Date:   Wed, 14 Sep 2016 10:55:46 -0700
From:   Hoan Tran <hotran@....com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Len Brown <lenb@...nel.org>,
        Prashanth Prakash <pprakash@...eaurora.org>,
        Ashwin Chaugule <ashwin.chaugule@...aro.org>,
        linux acpi <linux-acpi@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, Loc Ho <lho@....com>,
        Duc Dang <dhdang@....com>,
        Ashwin Chaugule <ashwinch@...gle.com>
Subject: Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag

On Wed, Sep 14, 2016 at 9:49 AM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> On Wednesday, September 14, 2016 08:45:14 AM Hoan Tran wrote:
>> On Tue, Aug 30, 2016 at 11:20 AM, Hoan Tran <hotran@....com> wrote:
>> > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@....com> wrote:
>> >> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
>> >> function to notify the mailbox framework about TX completion.
>> >>
>> >> Signed-off-by: Hoan Tran <hotran@....com>
>> >> ---
>> >> This patch is tested on top and depends on patch[1]:
>> >> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
>> >>  - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
>> >>
>> >>  drivers/acpi/cppc_acpi.c | 6 +++++-
>> >>  1 file changed, 5 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
>> >> index 2e98173..19606aa 100644
>> >> --- a/drivers/acpi/cppc_acpi.c
>> >> +++ b/drivers/acpi/cppc_acpi.c
>> >> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
>> >>                         last_cmd_cmpl_time = ktime_get();
>> >>         }
>> >>
>> >> -       mbox_client_txdone(pcc_channel, ret);
>> >> +       if (pcc_channel->mbox->txdone_irq)
>> >> +               mbox_chan_txdone(pcc_channel, ret);
>> >> +       else
>> >> +               mbox_client_txdone(pcc_channel, ret);
>> >> +
>> >>         return ret;
>> >>  }
>> >>
>> >> --
>> >> 1.9.1
>> >>
>> >
>> > Any feedbacks.
>> >
>> > Thanks
>> > Hoan
>>
>> Hi Rafael,
>>
>> Do you have any comments on this patch ?
>
> No, but can you please resend it (with the Reviewed-by tag from Prashanth,
> preferably)?  And please make sure it applies on my linux-next branch.

Hi Rafael,

I just resent the patch with Reviewed-by tag

Thanks
Hoan

>
> Thanks,
> Rafael
>