linux-kernel - Re: [PATCH v14 15/15] selftests/powerpc: Fix a build issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1473828948.2554.14.camel@gmail.com>
Date:   Wed, 14 Sep 2016 14:55:48 +1000
From:   Cyril Bur <cyrilbur@...il.com>
To:     wei.guo.simon@...il.com, linuxppc-dev@...ts.ozlabs.org
Cc:     Shuah Khan <shuah@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Chris Smart <chris@...troguy.com>,
        Suraj Jitindar Singh <sjitindarsingh@...il.com>,
        Michael Neuling <mikey@...ling.org>,
        Anshuman Khandual <khandual@...ux.vnet.ibm.com>,
        Jack Miller <jack@...ezen.org>,
        Rashmica Gupta <rashmicy@...il.com>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v14 15/15] selftests/powerpc: Fix a build issue

On Mon, 2016-09-12 at 15:33 +0800, wei.guo.simon@...il.com wrote:
> From: Anshuman Khandual <khandual@...ux.vnet.ibm.com>
> 
> Fixes the following build failure -
> 
> cp_abort.c:90:3: error: ‘for’ loop initial declarations are only
> allowed in C99 or C11 mode
>    for (int i = 0; i < NUM_LOOPS; i++) {
>    ^
> cp_abort.c:90:3: note: use option -std=c99, -std=gnu99, -std=c11 or
> -std=gnu11 to compile your code
> cp_abort.c:97:3: error: ‘for’ loop initial declarations are only
> allowed in C99 or C11 mode
>    for (int i = 0; i < NUM_LOOPS; i++) {
> 
> Signed-off-by: Anshuman Khandual <khandual@...ux.vnet.ibm.com>
> Signed-off-by: Simon Guo <wei.guo.simon@...il.com>

Reviewed-by: Cyril Bur <cyrilbur@...il.com>

> ---
>  tools/testing/selftests/powerpc/context_switch/cp_abort.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> b/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> index 5a5b55a..1ce7dce 100644
> --- a/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> +++ b/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> @@ -67,7 +67,7 @@ int test_cp_abort(void)
>  	/* 128 bytes for a full cache line */
>  	char buf[128] __cacheline_aligned;
>  	cpu_set_t cpuset;
> -	int fd1[2], fd2[2], pid;
> +	int fd1[2], fd2[2], pid, i;
>  	char c;
>  
>  	/* only run this test on a P9 or later */
> @@ -87,14 +87,14 @@ int test_cp_abort(void)
>  	FAIL_IF(pid < 0);
>  
>  	if (!pid) {
> -		for (int i = 0; i < NUM_LOOPS; i++) {
> +		for (i = 0; i < NUM_LOOPS; i++) {
>  			FAIL_IF((write(fd1[WRITE_FD], &c, 1)) != 1);
>  			FAIL_IF((read(fd2[READ_FD], &c, 1)) != 1);
>  			/* A paste succeeds if CR0 EQ bit is set */
>  			FAIL_IF(paste(buf) & 0x20000000);
>  		}
>  	} else {
> -		for (int i = 0; i < NUM_LOOPS; i++) {
> +		for (i = 0; i < NUM_LOOPS; i++) {
>  			FAIL_IF((read(fd1[READ_FD], &c, 1)) != 1);
>  			copy(buf);
>  			FAIL_IF((write(fd2[WRITE_FD], &c, 1) != 1));