linux-kernel - Re: [PATCH] clk-kona-setup: Use kmalloc_array() in parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <887a42c4-6cff-6d03-c62a-ffd3da128738@linaro.org>
Date:   Wed, 14 Sep 2016 13:45:11 -0500
From:   Alex Elder <elder@...aro.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        bcm-kernel-feedback-list@...adcom.com, linux-clk@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Matt Porter <mporter@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Vaishali Thakkar <vaishali.thakkar@...cle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] clk-kona-setup: Use kmalloc_array() in parent_process()

On 09/14/2016 01:40 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 14 Sep 2016 20:26:05 +0200
> 
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Probably not needed in practice, but safer nevertheless.

Reviewed-by: Alex Elder <elder@...aro.org>

> ---
>  drivers/clk/bcm/clk-kona-setup.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c
> index 526b0b0..a2e7e91 100644
> --- a/drivers/clk/bcm/clk-kona-setup.c
> +++ b/drivers/clk/bcm/clk-kona-setup.c
> @@ -586,8 +586,9 @@ static u32 *parent_process(const char *clocks[],
>  	}
>  
>  	/* There is at least one parent, so allocate a selector array */
> -
> -	parent_sel = kmalloc(parent_count * sizeof(*parent_sel), GFP_KERNEL);
> +	parent_sel = kmalloc_array(parent_count,
> +				   sizeof(*parent_sel),
> +				   GFP_KERNEL);
>  	if (!parent_sel) {
>  		pr_err("%s: error allocating %u parent selectors\n", __func__,
>  				parent_count);
>