linux-kernel - Re: [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160914192621.GA10559@localhost>
Date:   Wed, 14 Sep 2016 14:26:21 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Mayurkumar Patel <mayurkumar.patel@...el.com>,
        Rajat Jain <rajatja@...gle.com>,
        MikaWesterberg@...ux.intel.com, linux-pci@...r.kernel.org,
        Rafael J Wysocki <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org, Keith Busch <keith.busch@...el.com>,
        Luis Antonio Tarazona-Duarte 
        <luis.antonio.tarazona-duarte@...el.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine

On Wed, Sep 14, 2016 at 11:41:17AM +0300, Mika Westerberg wrote:
> On Mon, Sep 12, 2016 at 04:08:47PM -0500, Bjorn Helgaas wrote:
> > This is mostly Mayurkumar's work from [1] and [2].  I split [2] into two
> > patches and reworked it to keep the enclosing loop around the pciehp ISR.
> > 
> > The patches I added are trivial ones to clarify variable names, make dmesg
> > messages consistent, and remove useless code.
> > 
> > [1] 1471554479-42083-1-git-send-email-mayurkumar.patel@...el.com
> > [2] 92EBB4272BF81E4089A7126EC1E7B28466598F35@...MSX101.ger.corp.intel.com
> > 
> > ---
> > 
> > Bjorn Helgaas (5):
> >       PCI: pciehp: Rename pcie_isr() locals for clarity
> >       PCI: pciehp: Return IRQ_NONE when we can't read interrupt status
> >       PCI: pciehp: Remove unnecessary guard
> >       PCI: pciehp: Clean up dmesg "Slot(%s)" messages
> >       PCI: pciehp: Remove useless pciehp_get_latch_status() calls
> > 
> > Mayurkumar Patel (3):
> >       PCI: pciehp: Process all hotplug events before looking for new ones
> >       PCI: pciehp: Don't re-read Slot Status when queuing hotplug event
> >       PCI: pciehp: Don't re-read Slot Status when handling surprise event
> > 
> > 
> >  drivers/pci/hotplug/pciehp_ctrl.c |   83 ++++++++++++---------------------
> >  drivers/pci/hotplug/pciehp_hpc.c  |   94 ++++++++++++++++++++-----------------
> >  2 files changed, 82 insertions(+), 95 deletions(-)
> 
> I don't have any machines with native PCIe hotplug support enabled but
> regardless the series looks good to me,
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Thanks a lot for taking the time to review it!  I added your Reviewed-by.