linux-kernel - Re: drivers: staging: vme: Fixed some code style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2016 23:46:16 +0200
From:   Markus Böhme <markus.boehme@...lbox.org>
To:     Andrew Kanner <andrew.kanner@...il.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, manohar.vanga@...il.com,
        egor.ulieiskii@...il.com, linux-kernel@...r.kernel.org
Subject: Re: drivers: staging: vme: Fixed some code style warnings

On 09/14/2016 06:31 PM, Andrew Kanner wrote:
> ‎Thanks, I understood my fault, but haven't done this changes yet. I
> can't understand if I should reply to original message with v2 patch or
> send a new email with it?

Just send the patch with your revised commit message as a new mail, and
be sure to mark it as v2.

In future mails, please avoid top-posting. It is frowned upon because it
makes it unnecessarily hard to follow a discussion.

Thanks,
Markus

> 
> 
>   Исходное сообщение  
> От: Markus Böhme
> Отправлено: среда, 14 сентября 2016 г., 15:56
> Кому: Andrew Kanner; gregkh@...uxfoundation.org
> Копия: devel@...verdev.osuosl.org; manohar.vanga@...il.com; egor.ulieiskii@...il.com; linux-kernel@...r.kernel.org
> Тема: Re: drivers: staging: vme: Fixed some code style warnings
> 
> On 09/13/2016 12:31 AM, Andrew Kanner wrote:
>> Signed-off-by: Andrew Kanner <andrew.kanner@...il.com>
>> ---
>> drivers/staging/vme/devices/vme_pio2_core.c | 12 ++++++------
>> drivers/staging/vme/devices/vme_user.c | 2 +-
>> 2 files changed, 7 insertions(+), 7 deletions(-)
>> (snip)
> 
> Hello Andrew,
> 
> please be more specific in your subject line, e.g.
> "drivers: staging: vme: Convert to octal notation for permission bits".
> 
> Also don't forget to add a commit message to your patch with a short
> description what you are fixing and why. In your case it would be good
> to mention that you are fixing a checkpatch warning, and to include the
> warning message in your description. Then resend as V2.
> 
> Thanks,
> Markus
>