linux-kernel - Re: [PATCH] usb: use of_usb_get_dr_mode_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Sep 2016 00:56:18 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Hans de Goede <hdegoede@...hat.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Felipe Balbi <balbi@...com>,
        Peter Chen <peter.chen@...escale.com>,
        Rob Herring <robh@...nel.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: use of_usb_get_dr_mode_by_phy() inline helper without USB

On Wednesday, September 14, 2016 3:51:01 PM CEST Arnd Bergmann wrote:
> We have had two new PHY drivers call of_usb_get_dr_mode_by_phy()
> recently without having a dependency on CONFIG_USB_COMMON, resulting
> in a link error:
> 
> ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-meson-usb2.ko] undefined!
> 
> I fixed up the first one (sun4i) by adding the dependency, but
> if we get more of this, it's probably better to allow the PHY
> drivers to build without the dependency.
> 
> This changes the guard around declarations so we only refer to
> them when both CONFIG_OF and CONFIG_USB_COMMON are enabled,
> which is the right thing for all of the first calls but not the
> one that already has a correct check for USB_SUPPORT rather than
> USB_COMMON.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 5ed935458519 ("phy: meson: add USB2 PHY support for Meson8b and GXBB")
> 

Please hold off applying for now, the randconfig builder came up with a
new build failure after this one, I have to investigate tomorrow.

	Arnd