linux-kernel - Re: [PATCH for-next 12/20] IB/hns: Return bad wr while post send failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160915090742.GV26069@leon.nu>
Date:   Thu, 15 Sep 2016 12:07:42 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Salil Mehta <salil.mehta@...wei.com>
Cc:     dledford@...hat.com, xavier.huwei@...wei.com, oulijun@...wei.com,
        yisen.zhuang@...wei.com, xuwei5@...ilicon.com,
        mehta.salil.lnk@...il.com, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        "Dongdong Huang(Donald)" <hdd.huang@...wei.com>
Subject: Re: [PATCH for-next 12/20] IB/hns: Return bad wr while post send
 failed

On Fri, Sep 09, 2016 at 06:30:43PM +0800, Salil Mehta wrote:
> From: Lijun Ou <oulijun@...wei.com>
>
> While post failed, hns roce should return the wr failed to user.
> We omitted this while qp type is wrong and fixed it.
>
> Signed-off-by: Lijun Ou <oulijun@...wei.com>
> Signed-off-by: Dongdong Huang(Donald) <hdd.huang@...wei.com>
> Reviewed-by:  Wei Hu (Xavier) <xavier.huwei@...wei.com>
> Signed-off-by: Salil Mehta <salil.mehta@...wei.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index f4d2515..f0d6315 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -264,8 +264,10 @@ int hns_roce_v1_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
>  			}
>  			ind++;
>  		} else {

You should move the check of supported QPs to the beginning of post_send
and don't enter into the loop at all.

> -			dev_dbg(dev, "unSupported QP type\n");
> -			break;
> +			dev_err(dev, "unSupported QP type\n");

During initial review of hns driver, Lijun was asked to canonize debug
messages and don't use different styles and especially sUcH case.

> +			ret = -EOPNOTSUPP;
> +			*bad_wr = wr;

IMHO, the proper thing is to return NULL, because this is not wrong wr.

> +			goto out;
>  		}
>  	}
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)