linux-kernel - Re: [PATCH] leds: Only remove trigger if one is actually configured.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <75e5d60e-39e4-574f-5417-7532f1f19f1f@samsung.com>
Date:   Thu, 15 Sep 2016 13:48:16 +0200
From:   Jacek Anaszewski <j.anaszewski@...sung.com>
To:     Daniel Romell <danielromell@...il.com>, rpurdie@...ys.net
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Daniel Romell <daro@....se>
Subject: Re: [PATCH] leds: Only remove trigger if one is actually configured.

Hi Daniel,

On 09/14/2016 11:23 AM, Daniel Romell wrote:
> In led_trigger_remove(), check if there is a trigger
> configured before calling led_trigger_set(). This will
> prevent some unnecessary work, and more importantly stop
> sending uevent change events when no change has in fact
> occurred.
>
> Signed-off-by: Daniel Romell <daro@....se>
> ---
>  drivers/leds/led-triggers.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
> index 59d6a3e..28c7a66 100644
> --- a/drivers/leds/led-triggers.c
> +++ b/drivers/leds/led-triggers.c
> @@ -147,7 +147,8 @@ EXPORT_SYMBOL_GPL(led_trigger_set);
>  void led_trigger_remove(struct led_classdev *led_cdev)
>  {
>  	down_write(&led_cdev->trigger_lock);
> -	led_trigger_set(led_cdev, NULL);
> +	if (led_cdev->trigger)
> +		led_trigger_set(led_cdev, NULL);
>  	up_write(&led_cdev->trigger_lock);
>  }
>  EXPORT_SYMBOL_GPL(led_trigger_remove);
>

Thanks for the patch. Applied.

-- 
Best regards,
Jacek Anaszewski