linux-kernel - Re: [PATCH 14/26] drm/omap: dispc: Simplify _dispc_mgr_set_lcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22dea2e6-a5bb-ac3b-c229-0472c4670d53@ti.com>
Date:   Thu, 15 Sep 2016 15:09:11 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>, <thierry.reding@...il.com>,
        <airlied@...ux.ie>
CC:     <daniel.vetter@...ll.ch>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 14/26] drm/omap: dispc: Simplify
 _dispc_mgr_set_lcd_timings() parameters

On 01/09/16 14:23, Peter Ujfalusi wrote:
> Instead of passing the omap_video_timings structure's members individually,
> use the pointer to the struct.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
>  drivers/gpu/drm/omapdrm/dss/dispc.c | 38 ++++++++++++++-----------------------
>  1 file changed, 14 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
> index 858d87dd7fe8..915609be7a33 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -3141,29 +3141,23 @@ bool dispc_mgr_timings_ok(enum omap_channel channel,
>  	return true;
>  }
>  
> -static void _dispc_mgr_set_lcd_timings(enum omap_channel channel, int hsync_len,
> -		int hfp, int hbp, int vsw, int vfp, int vbp,
> -		enum omap_dss_signal_level vsync_level,
> -		enum omap_dss_signal_level hsync_level,
> -		enum omap_dss_signal_edge data_pclk_edge,
> -		enum omap_dss_signal_level de_level,
> -		enum omap_dss_signal_edge sync_pclk_edge)
> -
> +static void _dispc_mgr_set_lcd_timings(enum omap_channel channel,
> +				       struct omap_video_timings *ovt)

const pointer?

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)