linux-kernel - Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160915123155.GP21682@localhost.localdomain>
Date:   Thu, 15 Sep 2016 13:31:55 +0100
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
CC:     Lee Jones <lee.jones@...aro.org>, <linaro-kernel@...ts.linaro.org>,
        "Mark Brown" <broonie@...nel.org>,
        Krzysztof Kozłowski <k.kozlowski@...sung.com>,
        <patches@...nsource.wolfsonmicro.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing
 them

On Thu, Sep 15, 2016 at 04:47:00PM +0530, Viresh Kumar wrote:
> The order in which resources were freed in wm8994_device_exit() isn't
> correct. The regulators are removed before they are disabled.
> 
> Fix it by reordering code a bit, which makes it exact opposite of
> wm8994_device_init() as well.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Thanks,
Charles