linux-kernel - Re: [patch 11/32] greybus: camera driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2007086.FBCYJrjji1@avalon>
Date:   Thu, 15 Sep 2016 16:16:09 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        Johan Hovold <johan@...oldconsulting.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Sandeep Patil <sspatil@...gle.com>,
        Matt Porter <mporter@...nel.crashing.org>,
        John Stultz <john.stultz@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Alex Elder <elder@...aro.org>, David Lin <dtwlin@...gle.com>,
        Bryan O'Donoghue <pure.logic@...us-software.ie>,
        Vaibhav Agarwal <vaibhav.agarwal@...aro.org>,
        Mark Greer <mgreer@...malcreek.com>
Subject: Re: [patch 11/32] greybus: camera driver

Hi Greg,

Thank you for the patch.

On Thursday 15 Sep 2016 14:23:51 Greg Kroah-Hartman wrote:
> This driver implements the Greybus camera protocol.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/greybus/camera.c    | 1400 ++++++++++++++++++++++++++++++++++++++++
>  drivers/greybus/gb-camera.h |  127 +++
>  2 files changed, 1527 insertions(+)
> 
> --- /dev/null
> +++ b/drivers/greybus/camera.c
> @@ -0,0 +1,1400 @@

[snip]

> +/* GB format to media code map */
> +static const struct gb_camera_fmt_info gb_fmt_info[] = {
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_UYVY8_1X16,
> +		.gb_format = 0x01,
> +		.bpp	   = 16,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_NV12_1x8,
> +		.gb_format = 0x12,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_NV21_1x8,
> +		.gb_format = 0x13,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_YU12_1x8,
> +		.gb_format = 0x16,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_YV12_1x8,
> +		.gb_format = 0x17,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_JPEG_1X8,
> +		.gb_format = 0x40,
> +		.bpp	   = 0,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_GB_CAM_METADATA_1X8,
> +		.gb_format = 0x41,
> +		.bpp	   = 0,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_GB_CAM_DEBUG_DATA_1X8,
> +		.gb_format = 0x42,
> +		.bpp	   = 0,
> +	},

These two formats will likely not be accepted in their current state in the 
media subsystem, I would propose just dropping them.

> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SBGGR10_1X10,
> +		.gb_format = 0x80,
> +		.bpp	   = 10,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SGBRG10_1X10,
> +		.gb_format = 0x81,
> +		.bpp	   = 10,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SGRBG10_1X10,
> +		.gb_format = 0x82,
> +		.bpp	   = 10,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SRGGB10_1X10,
> +		.gb_format = 0x83,
> +		.bpp	   = 10,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SBGGR12_1X12,
> +		.gb_format = 0x84,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SGBRG12_1X12,
> +		.gb_format = 0x85,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SGRBG12_1X12,
> +		.gb_format = 0x86,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SRGGB12_1X12,
> +		.gb_format = 0x87,
> +		.bpp	   = 12,
> +	},
> +};

[snip]

-- 
Regards,

Laurent Pinchart