linux-kernel - Re: [PATCH 3/7 v3] sched: factorize PELT update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtAth1HNAqsLSOg+Vi2s-Le2gJmkkfp8KSA7mEJ5ssD7Dw@mail.gmail.com>
Date:   Thu, 15 Sep 2016 15:30:37 +0200
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Yuyang Du <yuyang.du@...el.com>,
        Morten Rasmussen <Morten.Rasmussen@....com>,
        Linaro Kernel Mailman List <linaro-kernel@...ts.linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Paul Turner <pjt@...gle.com>,
        Benjamin Segall <bsegall@...gle.com>
Subject: Re: [PATCH 3/7 v3] sched: factorize PELT update

On 15 September 2016 at 15:09, Peter Zijlstra <peterz@...radead.org> wrote:
> On Mon, Sep 12, 2016 at 09:47:48AM +0200, Vincent Guittot wrote:
>> @@ -3690,7 +3658,7 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr, int queued)
>>       /*
>>        * Ensure that runnable average is periodically updated.
>>        */
>> -     update_load_avg(curr, 1);
>> +     update_load_avg(curr, 1, 0);
>>       update_cfs_shares(cfs_rq);
>>
>
> I would find something like: update_load_avg(curr, UPDATE_TG), eg, make
> the second argument a bitflag instead of two arguments, much more
> readable.

OK, I'm going to use bitflag
>
> Do however check that it doesn't generate retarded code if you do that.

OK