linux-kernel - Re: [PATCH] staging: lustre: clean function declarations in class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160915145238.GB26016@kroah.com>
Date:   Thu, 15 Sep 2016 16:52:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     oleg.drokin@...el.com, andreas.dilger@...el.com,
        jsimmons@...radead.org, john.hammond@...el.com,
        shraddha.6596@...il.com, di.wang@...el.com,
        ksenija.stanojevic@...il.com, mike.rapoport@...il.com,
        andrew.perepechko@...gate.com, kirill.shutemov@...ux.intel.com,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        xie.baoyou@....com.cn, linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH] staging: lustre: clean function declarations in
 class_obd.c up

On Thu, Sep 15, 2016 at 09:51:27PM +0800, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:

Don't do that!  :)

> 
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for 'class_procfs_clean' [-Wmissing-prototypes]
> 
> In fact, both functions are declared in
> drivers/staging/lustre/lustre/obdclass/class_obd.c,but should be
> declared in a header file, thus can be recognized in other file.
> 
> So this patch moves the declarations into
> drivers/staging/lustre/lustre/include/obd_class.h.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/staging/lustre/lustre/include/obd_class.h  | 4 ++++
>  drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 --
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> index 9702ad4..9965a01 100644
> --- a/drivers/staging/lustre/lustre/include/obd_class.h
> +++ b/drivers/staging/lustre/lustre/include/obd_class.h
> @@ -1712,6 +1712,10 @@ int class_check_uuid(struct obd_uuid *uuid, __u64 nid);
>  void class_init_uuidlist(void);
>  void class_exit_uuidlist(void);
>  
> +/*linux-module.c*/

Here, have a ' '.  make that two...

thanks,

greg k-h