linux-kernel - Re: [PATCH v3] leds: Introduce userspace leds driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <313cbae5-fd66-f0ae-79a9-a3f4273d6f9c@samsung.com>
Date:   Thu, 15 Sep 2016 16:54:26 +0200
From:   Jacek Anaszewski <j.anaszewski@...sung.com>
To:     Pavel Machek <pavel@....cz>
Cc:     David Lechner <david@...hnology.com>,
        Richard Purdie <rpurdie@...ys.net>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        Marcel Holtmann <marcel@...tmann.org>
Subject: Re: [PATCH v3] leds: Introduce userspace leds driver

Hi Pavel,

On 09/15/2016 03:08 PM, Pavel Machek wrote:
> Hi!
>
>>> +	if (copy_from_user(&udev->user_dev, buffer,
>>> +			   sizeof(struct uleds_user_dev))) {
>>> +		ret = -EFAULT;
>>> +		goto out;
>>> +	}
>>> +
>>> +	if (!udev->user_dev.name[0]) {
>>> +		ret = -EINVAL;
>>> +		goto out;
>>> +	}
>>> +
>>> +	ret = led_classdev_register(NULL, &udev->led_cdev);
>>> +	if (ret < 0)
>>> +		goto out;
>
> No sanity checking on the name -> probably a security hole. Do not
> push this upstream before this is fixed.

Thanks for catching this.

David, please check if the LED name sticks to the LED class
device naming convention.

And one thing that caught my eye only now - please use
devm_led_classdev_register().

For now I'm dropping the patch.

-- 
Best regards,
Jacek Anaszewski