linux-kernel - Re: [tip:x86/vdso] x86/vdso: Only define map_vdso_randomized() if CONFIG_X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6b105722-7866-7947-c85f-29c90606e5e6@virtuozzo.com>
Date:   Thu, 15 Sep 2016 14:18:38 +0300
From:   Dmitry Safonov <dsafonov@...tuozzo.com>
To:     <hpa@...or.com>, <mingo@...nel.org>, <jpoimboe@...hat.com>,
        <peterz@...radead.org>, <dvlasenk@...hat.com>, <brgerst@...il.com>,
        <torvalds@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
        <tglx@...utronix.de>, <bp@...en8.de>, <luto@...nel.org>,
        <linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/vdso] x86/vdso: Only define map_vdso_randomized() if
 CONFIG_X86_64

On 09/15/2016 01:44 PM, tip-bot for Ingo Molnar wrote:
> Commit-ID:  3947f49302e4d1576ee58addd8d20b477faef5ea
> Gitweb:     http://git.kernel.org/tip/3947f49302e4d1576ee58addd8d20b477faef5ea
> Author:     Ingo Molnar <mingo@...nel.org>
> AuthorDate: Thu, 15 Sep 2016 08:56:21 +0200
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Thu, 15 Sep 2016 09:44:32 +0200
>
> x86/vdso: Only define map_vdso_randomized() if CONFIG_X86_64
>
> ... otherwise the compiler complains:
>
>    arch/x86/entry/vdso/vma.c:252:12: warning: ‘map_vdso_randomized’ defined but not used [-Wunused-function]
>
> But the #ifdeffery here is getting pretty ugly, so move around
> vdso_addr() as well to cluster the dependencies a bit more.
>
> It's still not particulary pretty though ...
>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Brian Gerst <brgerst@...il.com>
> Cc: Denys Vlasenko <dvlasenk@...hat.com>
> Cc: Dmitry Safonov <dsafonov@...tuozzo.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Josh Poimboeuf <jpoimboe@...hat.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: gorcunov@...nvz.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-mm@...ck.org
> Cc: oleg@...hat.com
> Cc: xemul@...tuozzo.com
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> ---

Thanks!

-- 
              Dmitry