linux-kernel - Re: [PATCH 2/2] x86/tsc: Add additional Intel CPU models to crystal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160915151600.GG5012@twins.programming.kicks-ass.net>
Date:   Thu, 15 Sep 2016 17:16:00 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Prarit Bhargava <prarit@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Rafael Aquini <aquini@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Len Brown <len.brown@...el.com>, lenb@...nel.org
Subject: Re: [PATCH 2/2] x86/tsc: Add additional Intel CPU models to
 crystal_khz whitelist

On Thu, Sep 15, 2016 at 11:04:18AM -0400, Prarit Bhargava wrote:
> +++ b/arch/x86/kernel/tsc.c
> @@ -689,11 +689,18 @@ unsigned long native_calibrate_tsc(void)
>  		switch (boot_cpu_data.x86_model) {
>  		case INTEL_FAM6_SKYLAKE_MOBILE:
>  		case INTEL_FAM6_SKYLAKE_DESKTOP:
> +		case INTEL_FAM6_KABYLAKE_MOBILE:
> +		case INTEL_FAM6_KABYLAKE_DESKTOP:
>  			crystal_khz = 24000;	/* 24.0 MHz */
>  			break;
> +		case INTEL_FAM6_SKYLAKE_X:
> +			crystal_khz = 24000;	/* 25.0 MHz */

					^^^  !=   ^^^^

did you mean to type: 25000 ?

> +			break;
>  		case INTEL_FAM6_ATOM_GOLDMONT:
>  			crystal_khz = 19200;	/* 19.2 MHz */
>  			break;
> +		default:
> +			crystal_khz = 0;
>  		}
>  	}
>  
> -- 
> 1.7.9.3
>