linux-kernel - RE: [PATCH -next] staging: fsl-mc: use list_del_init instead of list_del/INIT_LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0401MB2638DE453A1725C3252C9BA48DF00@VI1PR0401MB2638.eurprd04.prod.outlook.com>
Date:   Thu, 15 Sep 2016 14:03:15 +0000
From:   Stuart Yoder <stuart.yoder@....com>
To:     Wei Yongjun <weiyj.lk@...il.com>,
        "J . German Rivera" <German.Rivera@...escale.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        German Rivera <german.rivera@....com>,
        "Itai Katz" <itai.katz@....com>
CC:     Wei Yongjun <weiyongjun1@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: RE: [PATCH -next] staging: fsl-mc: use list_del_init instead of
 list_del/INIT_LIST_HEAD



> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@...il.com]
> Sent: Wednesday, September 14, 2016 9:27 PM
> To: J . German Rivera <German.Rivera@...escale.com>; Stuart Yoder <stuart.yoder@....com>; Greg Kroah-
> Hartman <gregkh@...uxfoundation.org>; German Rivera <german.rivera@....com>; Itai Katz
> <itai.katz@....com>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>; linux-kernel@...r.kernel.org; devel@...verdev.osuosl.org
> Subject: [PATCH -next] staging: fsl-mc: use list_del_init instead of list_del/INIT_LIST_HEAD
> 
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Using list_del_init() instead of list_del() + INIT_LIST_HEAD().
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-
> allocator.c
> index 2004fa7..1e06d28 100644
> --- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
> +++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
> @@ -142,8 +142,7 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device
>  		goto out_unlock;
>  	}
> 
> -	list_del(&resource->node);
> -	INIT_LIST_HEAD(&resource->node);
> +	list_del_init(&resource->node);
>  	res_pool->free_count--;
>  	res_pool->max_count--;
> 
> @@ -220,8 +219,7 @@ int __must_check fsl_mc_resource_allocate(struct fsl_mc_bus *mc_bus,
>  		    res_pool->free_count > res_pool->max_count))
>  		goto out_unlock;
> 
> -	list_del(&resource->node);
> -	INIT_LIST_HEAD(&resource->node);
> +	list_del_init(&resource->node);
> 
>  	res_pool->free_count--;
>  	error = 0;

Acked-by: Stuart Yoder <stuart.yoder@....com>