linux-kernel - Re: [PATCH] MMC: meson: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7hh99hktkp.fsf@baylibre.com>
Date:   Thu, 15 Sep 2016 09:37:26 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Carlo Caione <carlo@...one.org>, linux-mmc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MMC: meson: remove unused variable

Arnd Bergmann <arnd@...db.de> writes:

> The newly added meson mmc driver causes a build warning from an unused
> variable:
>
> drivers/mmc/host/meson-gxbb.c: In function 'meson_mmc_request_done':
> drivers/mmc/host/meson-gxbb.c:411:22: error: unused variable 'cmd' [-Werror=unused-variable]
>
> This removes the variable.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 4b331229dda9 ("MMC: meson: initial support for GXBB platforms")

kbuild test robot reported this also, so I already fixed it for linux-next.

Kevin

> ---
>  drivers/mmc/host/meson-gxbb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gxbb.c b/drivers/mmc/host/meson-gxbb.c
> index c73c62178764..193d343d0afe 100644
> --- a/drivers/mmc/host/meson-gxbb.c
> +++ b/drivers/mmc/host/meson-gxbb.c
> @@ -408,7 +408,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
>  {
>  	struct meson_host *host = mmc_priv(mmc);
> -	struct mmc_command *cmd = host->cmd;
>  
>  	WARN_ON(host->mrq != mrq);