linux-kernel - Re: [PATCH 4/4] input: serio: Replace timeval by timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABeXuvo+hFgP_pbOPd+X6RXUdqdpN-iDDYwE=z+0djnJtq3yig@mail.gmail.com>
Date:   Thu, 15 Sep 2016 10:21:02 -0700
From:   Deepa Dinamani <deepa.kernel@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>
Subject: Re: [PATCH 4/4] input: serio: Replace timeval by timespec64

On Tue, Sep 13, 2016 at 8:13 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday, September 13, 2016 7:10:05 AM CEST Deepa Dinamani wrote:
>> struct timeval is not y2038 safe.
>> All references to timeval will be deleted from the
>> kernel to make it y2038 safe.
>> Replace its uses by y2038 safe struct timespec64.
>>
>> The timestamps changed here only keep track of delta
>> times. These timestamps are also internal to kernel.
>> Hence, monotonic times are sufficient here.
>> The unit of the delta times is also changed in certain
>> cases to nanoseconds rather than microseconds. This is
>> in line with timespec64 which keeps time in nanoseconds.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
>>
>
> Looks all correct to me,
>
> Acked-by: Arnd Bergmann <arnd@...db.de>
>
> I think it could be done a little nicer using ktime_get()
> instead of ktime_get_ts64(), but probably nobody cares with
> this driver.

I tried to keep the processing same as timeval.
This could be changed to ktime_get() if that is preferred.

-Deepa