linux-kernel - Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1473960746.32273.62.camel@perches.com>
Date:   Thu, 15 Sep 2016 10:32:26 -0700
From:   Joe Perches <joe@...ches.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     bhumirks@...il.com, jrickertkc@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rts5208: Comparisons should place the constant
 on the right side of the test

On Thu, 2016-09-15 at 19:22 +0200, Sergio Paracuellos wrote:
> That's true. It seems that checkpatch script is getting a false 
> positive. Just trying to do checkpatch happy. Sorry for inconvenience.

Keeping the style consistent instead of taking the simplest path
to quiet the checkpatch messages is better.

Making N, min_N, max_N all lower case would be better.