linux-kernel - Re: [PATCH 2/2] x86/tsc: Add additional Intel CPU models to crystal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160915174346.GH5012@twins.programming.kicks-ass.net>
Date:   Thu, 15 Sep 2016 19:43:46 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     "Brown, Len" <len.brown@...el.com>
Cc:     Prarit Bhargava <prarit@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        Rafael Aquini <aquini@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        "lenb@...nel.org" <lenb@...nel.org>
Subject: Re: [PATCH 2/2] x86/tsc: Add additional Intel CPU models to
 crystal_khz whitelist

On Thu, Sep 15, 2016 at 04:08:36PM +0000, Brown, Len wrote:
> > +			crystal_khz = 24000;	/* 25.0 MHz */
> 
> I guess I prefer no comment over an incorrect comment.
> 

>From this I take it it should really have been 24 MHz and it could have
joined the existing case. I assumed (ha!) that since it had a special
separate case the comment was correct.