linux-kernel - Re: [PATCH] drm/radeon/radeon_device: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Sep 2016 19:44:42 +0200
From:   Christian König <christian.koenig@....com>
To:     Baoyou Xie <baoyou.xie@...aro.org>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "xie.baoyou@....com.cn" <xie.baoyou@....com.cn>
Subject: Re: [PATCH] drm/radeon/radeon_device: remove unused function

Am 15.09.2016 um 16:13 schrieb Baoyou Xie:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/radeon/radeon_device.c:1961:5: warning: no previous prototype for 'radeon_debugfs_init' [-Wmissing-prototypes]
> drivers/gpu/drm/radeon/radeon_device.c:1966:6: warning: no previous prototype for 'radeon_debugfs_cleanup' [-Wmissing-prototypes]
>
> In fact, these functions are dummy, but can be removed,
> so this patch removes them.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Reviewed-by: Christian König <christian.koenig@....com>.

> ---
>   drivers/gpu/drm/radeon/radeon_device.c | 11 -----------
>   drivers/gpu/drm/radeon/radeon_drv.c    |  9 ---------
>   2 files changed, 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
> index a00dd2f..63447f1 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -1956,14 +1956,3 @@ static void radeon_debugfs_remove_files(struct radeon_device *rdev)
>   	}
>   #endif
>   }
> -
> -#if defined(CONFIG_DEBUG_FS)
> -int radeon_debugfs_init(struct drm_minor *minor)
> -{
> -	return 0;
> -}
> -
> -void radeon_debugfs_cleanup(struct drm_minor *minor)
> -{
> -}
> -#endif
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 07e4493..86bab2e 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -156,11 +156,6 @@ void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>   extern long radeon_kms_compat_ioctl(struct file *filp, unsigned int cmd,
>   				    unsigned long arg);
>   
> -#if defined(CONFIG_DEBUG_FS)
> -int radeon_debugfs_init(struct drm_minor *minor);
> -void radeon_debugfs_cleanup(struct drm_minor *minor);
> -#endif
> -
>   /* atpx handler */
>   #if defined(CONFIG_VGA_SWITCHEROO)
>   void radeon_register_atpx_handler(void);
> @@ -531,10 +526,6 @@ static struct drm_driver kms_driver = {
>   	.disable_vblank = radeon_disable_vblank_kms,
>   	.get_vblank_timestamp = radeon_get_vblank_timestamp_kms,
>   	.get_scanout_position = radeon_get_crtc_scanoutpos,
> -#if defined(CONFIG_DEBUG_FS)
> -	.debugfs_init = radeon_debugfs_init,
> -	.debugfs_cleanup = radeon_debugfs_cleanup,
> -#endif
>   	.irq_preinstall = radeon_driver_irq_preinstall_kms,
>   	.irq_postinstall = radeon_driver_irq_postinstall_kms,
>   	.irq_uninstall = radeon_driver_irq_uninstall_kms,