linux-kernel - Re: [PATCH 4/7] power, workqueue: remove keventd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de6aaf51-47ff-b357-e4be-301900b2e898@intel.com>
Date:   Fri, 16 Sep 2016 01:55:28 +0200
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        jiangshanlai@...il.com, akpm@...ux-foundation.org,
        kernel-team@...com, Qiao Zhou <qiaozhou@...micro.com>
Subject: Re: [PATCH 4/7] power, workqueue: remove keventd_up() usage

On 9/15/2016 9:30 PM, Tejun Heo wrote:
> Now that workqueue can handle work item queueing/cancelling from very
> early during boot, there is no need to gate cancel_delayed_work_sync()
> while !keventd_up().  Remove it.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Qiao Zhou <qiaozhou@...micro.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> Hello,
>
> This change depends on an earlier workqueue patch and is followed by a
> patch to remove keventd_up().  It'd be great if it can be routed
> through the wq/for-4.9 branch.

I don't see any problems with that.

Please feel free to add my ACK to the patch if necessary/useful.

Thanks,
Rafael


>   kernel/power/qos.c | 11 +----------
>   1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/kernel/power/qos.c b/kernel/power/qos.c
> index 168ff44..97b0df7 100644
> --- a/kernel/power/qos.c
> +++ b/kernel/power/qos.c
> @@ -482,16 +482,7 @@ void pm_qos_update_request(struct pm_qos_request *req,
>   		return;
>   	}
>   
> -	/*
> -	 * This function may be called very early during boot, for example,
> -	 * from of_clk_init(), where irq needs to stay disabled.
> -	 * cancel_delayed_work_sync() assumes that irq is enabled on
> -	 * invocation and re-enables it on return.  Avoid calling it until
> -	 * workqueue is initialized.
> -	 */
> -	if (keventd_up())
> -		cancel_delayed_work_sync(&req->work);
> -
> +	cancel_delayed_work_sync(&req->work);
>   	__pm_qos_update_request(req, new_value);
>   }
>   EXPORT_SYMBOL_GPL(pm_qos_update_request);