linux-kernel - Re: [PATCH] phy: sun4i-usb: Fix build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57DBAF31.4030604@ti.com>
Date:   Fri, 16 Sep 2016 14:07:05 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Axel Lin <axel.lin@...ics.com>
CC:     Hans de Goede <hdegoede@...hat.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        <linux-kernel@...r.kernel.org>, "arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH] phy: sun4i-usb: Fix build dependency

+Arnd

Hi,

On Friday 16 September 2016 07:45 AM, Axel Lin wrote:
> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
> build error.
> 
> ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1

Arnd was trying to solve the same issue.

Thanks
Kishon
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/phy/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index cc27c12..b65aba0 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -258,6 +258,8 @@ config PHY_SUN4I_USB
>  	depends on RESET_CONTROLLER
>  	depends on EXTCON
>  	depends on POWER_SUPPLY
> +	depends on USB_SUPPORT
> +	select USB_COMMON
>  	select GENERIC_PHY
>  	help
>  	  Enable this to support the transceiver that is part of Allwinner
>