linux-kernel - Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160916084121.GC2415@lst.de>
Date:   Fri, 16 Sep 2016 10:41:21 +0200
From:   Christoph Hellwig <hch@....de>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     Keith Busch <keith.busch@...el.com>, Jens Axboe <axboe@...com>,
        linux-nvme@...ts.infradead.org, Christoph Hellwig <hch@....de>,
        linux-kernel@...r.kernel.org,
        J Freyensee <james_p_freyensee@...ux.intel.com>
Subject: Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to
        nvme_get/set_features()

On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote:
> Any user I can imagine that needs a buffer at all will want to pass
> a pointer directly.  There are no currently callers that use
> buffers, so this change is painless, and it will make it much easier
> to start using features that use buffers (e.g. APST).
> 
> Signed-off-by: Andy Lutomirski <luto@...nel.org>
> ---

Looks good mostly good, but a nitpick below:

> +	/*
> +	 * Casting buffer to void* is safe here: __nvme_submit_sync_cmd knows
> +	 * that we're writing because it decodes the opcode.
> +	 */
> +	ret = __nvme_submit_sync_cmd(dev->admin_q, &c, &cqe,
> +			(void *)buffer, buflen, 0, NVME_QID_ANY, 0, 0);

Cant we just drop the const annotation to avoid these casts?