linux-kernel - Re: [PATCH] staging: android ion/hisi: fix dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08266540-f2ea-7e18-dc60-cca5ce880631@redhat.com>
Date:   Thu, 15 Sep 2016 19:10:00 -0700
From:   Laura Abbott <labbott@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Sumit Semwal <sumit.semwal@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Riley Andrews <riandrews@...roid.com>,
        Chen Feng <puck.chen@...ilicon.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android ion/hisi: fix dependencies

On 09/15/2016 08:57 AM, Arnd Bergmann wrote:
> The newly added Hi6220 Ion code fails to build when the ION_OF helpers
> are not present:
>
> drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove':
> hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to `ion_destroy_platform_data'
> drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_probe':
> hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to `ion_parse_dt'
> hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to `ion_destroy_platform_data'
>
> This selects the symbol when needed.
>

Acked-by: Laura Abbott <labbott@...hat.com>

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC platform")
> ---
>  drivers/staging/android/ion/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 94105544feef..c8fb4134c55d 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -36,6 +36,7 @@ config ION_TEGRA
>  config ION_HISI
>  	tristate "Ion for Hisilicon"
>  	depends on ARCH_HISI && ION
> +	select ION_OF
>  	help
>  	  Choose this option if you wish to use ion on Hisilicon Platform.
>
>