linux-kernel - Re: [PATCH] i2c: i2c-mux-pca954x: retry updating the mux selection on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1821185f-d97b-5394-a90e-d6b67545e06f@axentia.se>
Date:   Fri, 16 Sep 2016 09:01:17 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Wolfram Sang <wsa@...-dreams.de>
CC:     <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: i2c-mux-pca954x: retry updating the mux selection on
 failure

[Resend, with lists added back...]

On 2016-09-15 21:52, Wolfram Sang wrote:
> On Wed, Sep 14, 2016 at 03:24:12PM +0200, Peter Rosin wrote:
>> The cached value of the last selected channel prevents retries on the
>> next call, even on failure to update the selected channel. Fix that.
>>
>> Signed-off-by: Peter Rosin <peda@...ntia.se>
> 
> Looks good. Is this 4.8 material or rather 4.9?

I have no real-world event or report backing the change, but it is
simple enough and fixes problems that are potentially very hard to
detect/reproduce. Certainly fodder for 4.8 and probably stable as
well (if you care). But no biggie, so personally I don't mind if
you wait until 4.9, but then again I don't depend on the driver...

Cheers,
Peter