linux-kernel - Re: [PATCH v2] skd: fix assert typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160916115930.ydfcgohliglkricg@linux-x5ow.site>
Date:   Fri, 16 Sep 2016 13:59:30 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Eric Engestrom <eric.engestrom@...tec.com>
Cc:     linux-kernel@...r.kernel.org, Jeff Moyer <jmoyer@...hat.com>,
        Jens Axboe <axboe@...com>,
        Dan Williams <dan.j.williams@...el.com>,
        Ming Lin <ming.l@....samsung.com>,
        Mike Christie <mchristi@...hat.com>
Subject: Re: [PATCH v2] skd: fix assert typo

On Fri, Sep 16, 2016 at 10:31:23AM +0100, Eric Engestrom wrote:
> The assert was missing a `!` to become active, but since that would only turn
> it into a complicated codepath for a pr_err(), let's simply replace it.
> 
> CC: Jeff Moyer <jmoyer@...hat.com>
> Signed-off-by: Eric Engestrom <eric.engestrom@...tec.com>
> ---

Looks ok,
Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850