linux-kernel - Re: [RFC/RFT][PATCH v3 2/5] driver core: Functional dependencies tracking support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Sep 2016 14:06:02 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Mark Brown <broonie@...nel.org>,
        Lukas Wunner <lukas@...ner.de>,
        Kevin Hilman <khilman@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        "Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [RFC/RFT][PATCH v3 2/5] driver core: Functional dependencies
 tracking support

On Fri, Sep 16, 2016 at 9:53 AM, Marek Szyprowski
<m.szyprowski@...sung.com> wrote:
> Hi Rafael,
>
>
> On 2016-09-16 00:06, Rafael J. Wysocki wrote:
>>
>> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>>

[cut]

>> +/**
>> + * device_links_no_driver - Update links of a device without a driver.
>> + * @dev: Device without a drvier.
>> + *
>> + * Delete all non-persistent links from this device to any suppliers.
>> + *
>> + * Persistent links stay around, but their status is changed to
>> "available",
>> + * unless they already are in the "supplier unbind in progress" state in
>> which
>> + * case they need not be updated.
>> + *
>> + * Links with the DEVICE_LINK_STATELESS flag set are ignored.
>> + */
>> +void device_links_no_driver(struct device *dev)
>> +{
>> +       struct device_link *link, *ln;
>> +
>> +       mutex_lock(&device_links_lock);
>> +
>> +       list_for_each_entry_safe_reverse(link, ln,
>> &dev->links_to_suppliers, c_node)
>
>
> missing "{"
>
>> +               if (link->flags & DEVICE_LINK_STATELESS)
>> +                       continue;
>> +
>> +               if (link->flags & DEVICE_LINK_AUTOREMOVE) {
>> +                       __device_link_del(link);
>> +               } else {
>> +                       spin_lock(&link->lock);
>> +
>> +                       if (link->status != DEVICE_LINK_SUPPLIER_UNBIND)
>> +                               link->status = DEVICE_LINK_AVAILABLE;
>> +
>> +                       spin_unlock(&link->lock);
>> +               }
>
>
> missing "}"
>

Sorry for the breakage and thanks for the fix!

Rafael